Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(planning): update args name #671

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 31, 2023

Description

See autowarefoundation/autoware.universe#5448.

Tests performed

Evaluator

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2255356) 0.00% compared to head (b19d393) 0.00%.

❗ Current head b19d393 differs from pull request most recent head 9052d62. Consider uploading reports for the commit 9052d62 to get more accurate results

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #671   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@satoshi-ota satoshi-ota force-pushed the refactor/behavior-xml-launch branch from b19d393 to 9052d62 Compare November 1, 2023 04:43
Copy link
Contributor

@TomohitoAndo TomohitoAndo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit e76498c into main Nov 2, 2023
9 of 10 checks passed
@satoshi-ota satoshi-ota deleted the refactor/behavior-xml-launch branch November 2, 2023 07:23
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants