-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer): add Simple1DFilter params to parameter file #710
Merged
KYabuuchi
merged 2 commits into
autowarefoundation:main
from
meliketanrikulu:feat(ekf_localizer)AddSimple1DFilterparamstoparameterfile
Jan 15, 2024
Merged
refactor(ekf_localizer): add Simple1DFilter params to parameter file #710
KYabuuchi
merged 2 commits into
autowarefoundation:main
from
meliketanrikulu:feat(ekf_localizer)AddSimple1DFilterparamstoparameterfile
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: meliketanrikulu <[email protected]>
3 tasks
meliketanrikulu
changed the title
feat(ekf_localizer): Add Simple1DFilter params to parameter file
refactor(ekf_localizer): Add Simple1DFilter params to parameter file
Dec 21, 2023
meliketanrikulu
changed the title
refactor(ekf_localizer): Add Simple1DFilter params to parameter file
refactor(ekf_localizer): add Simple1DFilter params to parameter file
Dec 21, 2023
4 tasks
kminoda
reviewed
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@meliketanrikulu Please fix pre-commit |
KYabuuchi
requested changes
Dec 27, 2023
@kminoda This PR has long been left undone. This is not good so I have committed myself to it. |
kminoda
approved these changes
Jan 15, 2024
KYabuuchi
approved these changes
Jan 15, 2024
This was referenced Jan 15, 2024
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
…behind the ego vehicle (autowarefoundation#710) Signed-off-by: Owen-Liuyuxuan <[email protected]> Co-authored-by: Owen-Liuyuxuan <[email protected]>
mitukou1109
pushed a commit
to mitukou1109/autoware_launch
that referenced
this pull request
Dec 23, 2024
chore: sync awf-latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple1DFilter parameters will be added to the parameter file to be able to change these parameters from the parameter file.
This PR related this PR: autowarefoundation/autoware.universe#5707
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.