Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_container): add glog #791

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 15, 2024

MUST BE MERGED WITH autowarefoundation/autoware.universe#6081

See also tier4/aip_launcher#196 for motivation behind this PR.

Description

See autowarefoundation/autoware.universe#6081

Tests performed

See autowarefoundation/autoware.universe#6081

Effects on system behavior

See autowarefoundation/autoware.universe#6081

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as ready for review January 15, 2024 09:54
@kminoda kminoda requested review from miursh and YoshiRi January 15, 2024 09:54
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda closed this Jan 16, 2024
technolojin pushed a commit to technolojin/autoware_launch that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants