feat: always separate lidar preprocessing from pointcloud_container #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
7 tasks
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
kminoda
changed the title
Signed-off-by: kminoda <[email protected]>
Signed-off-by: kminoda <[email protected]>
KYabuuchi
reviewed
Jan 17, 2024
autoware_launch/launch/components/tier4_localization_component.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: kminoda <[email protected]>
KYabuuchi
reviewed
Jan 17, 2024
autoware_launch/launch/components/tier4_localization_component.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: kminoda <[email protected]>
This was referenced Jan 19, 2024
7 tasks
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Feb 6, 2024
…utowarefoundation#796) * feat!: replace use_pointcloud_container Signed-off-by: kminoda <[email protected]> * change default value Signed-off-by: kminoda <[email protected]> * remove from planning Signed-off-by: kminoda <[email protected]> * revert: revert change in planning.launch Signed-off-by: kminoda <[email protected]> * revert: revert rename of use_pointcloud_container Signed-off-by: kminoda <[email protected]> * revert: revert pointcloud_container launch Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * feat: move glog to pointcloud_container.launch.py * revert: revert unnecessary change Signed-off-by: kminoda <[email protected]> * revert: revert glog porting Signed-off-by: kminoda <[email protected]> * fix: fix comment in localization launch Signed-off-by: kminoda <[email protected]> * style(pre-commit): autofix * remove pointcloud_container_name from localization launcher Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
maxime-clem
pushed a commit
to maxime-clem/autoware_launch
that referenced
this pull request
Apr 8, 2024
…n#796) * feat(start_planner): allow lane departure check override (autowarefoundation#893) new param added Signed-off-by: Daniel Sanchez <[email protected]> * set lane departure check as true by default Signed-off-by: Daniel Sanchez <[email protected]> * fix changed value Signed-off-by: Daniel Sanchez <[email protected]> * fix repeated value Signed-off-by: Daniel Sanchez <[email protected]> --------- Signed-off-by: Daniel Sanchez <[email protected]>
technolojin
pushed a commit
to technolojin/autoware_launch
that referenced
this pull request
Nov 25, 2024
…0/disable_gnss_error chore: disable gnss error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See autowarefoundation/autoware.universe#6091
Related links
See autowarefoundation/autoware.universe#6091
Tests performed
See autowarefoundation/autoware.universe#6091
Notes for reviewers
See autowarefoundation/autoware.universe#6091
Note for X2 team (TIER IV)
The modification in tier4_localization_component.launch.xml should be incorporated into autoware_launch.x2 carefully. Specifically, please change the target container name from
/sensing/lidar/top/...to the one you use for localization.Interface changes
See autowarefoundation/autoware.universe#6091
Effects on system behavior
See autowarefoundation/autoware.universe#6091
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.