refactor(image_projection_based_fusion): rework params

[badai-nguyen]

Description

• This rename the param file as refactor(image_projection_based_fusion): rework param autoware.universe#6289

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[Shin-kyoto]

@badai-nguyen
Could you please rebase to the latest?

[Shin-kyoto]

@badai-nguyen

Please add these params to https://github.com/autowarefoundation/autoware_launch/blob/main/autoware_launch/config/perception/object_recognition/detection/lidar_model/pointpainting.param.yaml, too

    # fusion interface common params
    debug_mode: false
    image_buffer_size: 15
    filter_scope_min_x: -100.0
    filter_scope_min_y: -100.0
    filter_scope_min_z: -100.0
    filter_scope_max_x: 100.0
    filter_scope_max_y: 100.0
    filter_scope_max_z: 100.0

That is because pointpainting uses roi_sync_param in https://github.com/autowarefoundation/autoware.universe/blob/1ed6fac11a9851c12ede1ec34409204d799d9863/perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml#L26

I checked this PR with evaluator, and I got the error below.

[ERROR] [launch_ros.actions.load_composable_nodes]: Failed to load node 'pointpainting' of type 'image_projection_based_fusion::PointPaintingFusionNode' in container 'pointcloud_container': Component constructor threw an exception: Statically typed parameter 'filter_scope_min_x' must be initialized.

And please run the evaluator on the condition that "perception_mode" is "camera_lidar_fusion" and "lidar_detection_model" is "pointpainting", and paste the link to the result of evaluator.
This example will be helpful for you.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity.

[Shin-kyoto]

@badai-nguyen

I did NOT run autoware with this PR. I checked the code only. Please check this PR runs correctly.

[miursh]

LGTM!
Could you change the file in autoware.universe and launch files as well?

[badai-nguyen]

@miursh I fogot to link the autoware.universe PR. I already changed here autowarefoundation/autoware.universe#6289. Could you review it as well?