Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(start/goal_planner): remove unused param and update time horizon for goal planner's safety check #863

Merged

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

change for the PR

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start/goal_planner): remove unused param and update time horizon for goal planner's safety check refactor(start/goal planner): remove unused param and update time horizon for goal planner's safety check Feb 7, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start/goal planner): remove unused param and update time horizon for goal planner's safety check refactor(start/goal_planner): remove unused param and update time horizon for goal planner's safety check Feb 7, 2024
@kosuke55
Copy link
Contributor

kosuke55 commented Feb 7, 2024

please drop unrelated commits before merging.

and this PR changes value, so feat seems better than refactor

Signed-off-by: kyoichi-sugahara <[email protected]>
Signed-off-by: kyoichi-sugahara <[email protected]>
@kyoichi-sugahara kyoichi-sugahara force-pushed the refactor/remove_unused_param_and_fix_time_horizon branch from 4045617 to 5808bb6 Compare February 7, 2024 16:21
@kyoichi-sugahara kyoichi-sugahara changed the title refactor(start/goal_planner): remove unused param and update time horizon for goal planner's safety check feat(start/goal_planner): remove unused param and update time horizon for goal planner's safety check Feb 7, 2024
@kyoichi-sugahara
Copy link
Contributor Author

@kosuke55
I'm sorry for being too lazy 🙏
Fixed the PR 🦾

@kyoichi-sugahara kyoichi-sugahara merged commit 7623f6f into main Feb 7, 2024
11 of 12 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/remove_unused_param_and_fix_time_horizon branch February 7, 2024 16:25
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 19, 2024
… for goal planner's safety check (autowarefoundation#863)

* remove unused param

Signed-off-by: kyoichi-sugahara <[email protected]>

* update safety check time horizon

Signed-off-by: kyoichi-sugahara <[email protected]>

---------

Signed-off-by: kyoichi-sugahara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants