Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_planning_msgs)!: remove PathWithLaneId msgs #86

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Apr 25, 2024

Description

PathWithLaneId is not an official interface for Autoware: https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/components/planning/

If this must be added, it should go under autoware_internal_msgs repository.
For now, the message isn't used in the code so there is not issue with removing the message.

Tests performed

Autoware builds without an error.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r mitsudome-r requested a review from yukkysaito April 25, 2024 06:00
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r changed the title feat!(autoware_planning_msgs): remove PathWithLaneId msgs feat(autoware_planning_msgs)!: remove PathWithLaneId msgs Apr 25, 2024
Copy link

stale bot commented Jun 25, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale label Jun 25, 2024
@stale stale bot removed the status:stale label Jun 25, 2024
@esteve
Copy link
Contributor

esteve commented Jun 25, 2024

@youtalk I believe I don't have write access to this repo, could you review these changes and approve them? PRs need two approvals from people with write access and @yukkysaito already approved this PR. Thanks.

@esteve esteve requested a review from youtalk June 25, 2024 08:53
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@esteve Thank you for your mention.

@youtalk youtalk enabled auto-merge (squash) June 25, 2024 09:06
@youtalk youtalk disabled auto-merge June 25, 2024 10:12
@youtalk
Copy link
Member

youtalk commented Jun 25, 2024

@mitsudome-r I think the current branch protection rule is too strong. We cannot merge any PRs to main. Could you fix it?

https://github.com/autowarefoundation/autoware_msgs/rules/847626?ref=refs%2Fheads%2Fmain

@xmfcx xmfcx closed this Jun 25, 2024
@xmfcx xmfcx reopened this Jun 25, 2024
@xmfcx
Copy link
Collaborator

xmfcx commented Jun 25, 2024

It says "The base branch does not allow updates." checking again.

@youtalk youtalk enabled auto-merge (squash) June 25, 2024 10:35
@xmfcx
Copy link
Collaborator

xmfcx commented Jun 25, 2024

image

What is being merged btw?

@xmfcx xmfcx disabled auto-merge June 25, 2024 10:37
Copy link
Collaborator

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr changes nothing

@esteve
Copy link
Contributor

esteve commented Jun 25, 2024

@xmfcx you're right, looks like this message was already removed in main https://github.com/autowarefoundation/autoware_msgs/tree/main/autoware_planning_msgs/msg

@xmfcx
Copy link
Collaborator

xmfcx commented Jun 25, 2024

Thanks @esteve closing it then.

@xmfcx xmfcx closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants