-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_planning_msgs)!: remove PathWithLaneId msgs #86
feat(autoware_planning_msgs)!: remove PathWithLaneId msgs #86
Conversation
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been automatically marked as stale because it has not had recent activity. |
@youtalk I believe I don't have write access to this repo, could you review these changes and approve them? PRs need two approvals from people with write access and @yukkysaito already approved this PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@esteve Thank you for your mention.
@mitsudome-r I think the current branch protection rule is too strong. We cannot merge any PRs to main. Could you fix it? https://github.com/autowarefoundation/autoware_msgs/rules/847626?ref=refs%2Fheads%2Fmain |
It says "The base branch does not allow updates." checking again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this pr changes nothing
@xmfcx you're right, looks like this message was already removed in main https://github.com/autowarefoundation/autoware_msgs/tree/main/autoware_planning_msgs/msg |
Thanks @esteve closing it then. |
Description
PathWithLaneId is not an official interface for Autoware: https://autowarefoundation.github.io/autoware-documentation/main/design/autoware-interfaces/components/planning/
If this must be added, it should go under autoware_internal_msgs repository.
For now, the message isn't used in the code so there is not issue with removing the message.
Tests performed
Autoware builds without an error.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.