Use findUsages in missing_referrers_for_traffic_lights

Signed-off-by: TaikiYamada4 <[email protected]>
autowarefoundation · Dec 5, 2024 · 1a077ae · 1a077ae
1 parent 1232fca
commit 1a077ae
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 28 deletions.
diff --git a/.../lanelet2_map_validator/validators/traffic_light/missing_referrers_for_traffic_lights.hpp b/.../lanelet2_map_validator/validators/traffic_light/missing_referrers_for_traffic_lights.hpp
@@ -36,17 +36,6 @@ class MissingReferrersForTrafficLightsValidator : public lanelet::validation::Ma
    */
   lanelet::validation::Issues check_missing_referrers_for_traffic_lights(
     const lanelet::LaneletMap & map);
-
-  /**
-   * @brief Returns lanelets that refers the regulatory element specified by the input id
-   * from the input lanelet map.
-   *
-   * @param map
-   * @param reg_elem_id
-   * @return lanelet::ConstLanelets
-   */
-  lanelet::ConstLanelets collect_referring_lanelets(
-    const lanelet::LaneletMap & map, const lanelet::Id reg_elem_id);
 };
 }  // namespace lanelet::autoware::validation
 

diff --git a/...elet2_map_validator/src/validators/traffic_light/missing_referrers_for_traffic_lights.cpp b/...elet2_map_validator/src/validators/traffic_light/missing_referrers_for_traffic_lights.cpp
@@ -51,8 +51,8 @@ MissingReferrersForTrafficLightsValidator::check_missing_referrers_for_traffic_l
     }
 
     // At least one lanelet should refer a traffic_light regulatory element
-    const lanelet::ConstLanelets referring_lanelets =
-      collect_referring_lanelets(map, reg_elem->id());
+    const lanelet::ConstLanelets referring_lanelets = map.laneletLayer.findUsages(reg_elem);
+
     if (referring_lanelets.size() == 0) {
       issues.emplace_back(
         lanelet::validation::Severity::Error, lanelet::validation::Primitive::RegulatoryElement,
@@ -66,19 +66,4 @@ MissingReferrersForTrafficLightsValidator::check_missing_referrers_for_traffic_l
 
   return issues;
 }
-
-lanelet::ConstLanelets MissingReferrersForTrafficLightsValidator::collect_referring_lanelets(
-  const lanelet::LaneletMap & map, const lanelet::Id target_reg_elem_id)
-{
-  lanelet::ConstLanelets lanelet_group;
-  for (const lanelet::ConstLanelet & lanelet : map.laneletLayer) {
-    for (lanelet::RegulatoryElementConstPtr reg_elem : lanelet.regulatoryElements()) {
-      if (reg_elem->id() == target_reg_elem_id) {
-        lanelet_group.push_back(lanelet);
-      }
-    }
-  }
-  return lanelet_group;
-}
-
 }  // namespace lanelet::autoware::validation