Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map): port lanelet2_map_preprocessor from autoware.universe #112

Merged

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented Sep 6, 2024

Description

This PR will add map/autoware_lanelet2_map_utils which is a port of autoware.universe/map/util/lanelet2_map_preprocessor .

After this PR, the lanelet2_map_preprocessor in the autoware.universe will be get removed and only the link to this package remains.

Changes

  • add autoware_lanelet2_map_utils
  • add dependency autoware_lanelet2_extension to build_depends.repo

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: a-maumau <[email protected]>
a-maumau and others added 2 commits September 9, 2024 10:08
Signed-off-by: a-maumau <[email protected]>

Co-authored-by: Yamato Ando <[email protected]>
Signed-off-by: a-maumau <[email protected]>

Co-authored-by: Yamato Ando <[email protected]>
@a-maumau a-maumau force-pushed the mau/feat/lanelet2_map_utils branch from 4c88e5a to 2d22105 Compare September 9, 2024 01:09
@a-maumau
Copy link
Contributor Author

a-maumau commented Sep 9, 2024

@YamatoAndo I applied your suggestions in 7b44197 and 2d22105 .

Signed-off-by: a-maumau <[email protected]>
@a-maumau
Copy link
Contributor Author

a-maumau commented Sep 9, 2024

I change the tier to TIER for other files too.

@YamatoAndo YamatoAndo merged commit 5bd5865 into autowarefoundation:main Sep 9, 2024
26 checks passed
@a-maumau a-maumau deleted the mau/feat/lanelet2_map_utils branch September 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants