feat(driving_environment_analyzer): add new package #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
| explicit DrivingEnvironmentAnalyzer(const rclcpp::NodeOptions & node_options); | ||
|
|
||
| private: | ||
| bool isEnoughData(const bool use_map_in_bag); |
There was a problem hiding this comment.
nits: hasEnoughData or isDataReady
There was a problem hiding this comment.
Fixed in c524799.
Comment on lines
+336
to
+337
| route_handler_.setMap(*msg); | ||
| has_map_data_ = true; |
There was a problem hiding this comment.
nits:
route_handler_ and has_map_data_ can be converted to one variable by making route_handler_ std::optional?
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 23 24 +1
Lines 2130 2292 +162
======================================
- Misses 2130 2292 +162
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
driving_environment_analyzertool.Related links
Related PR: autowarefoundation/autoware.universe#6496
Tests performed
Test with ROSBAG.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.