Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(autoware_lanelet2_map_validator): add requirement vm-02-02 to autoware_requirement_set #143

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Nov 1, 2024

Description

There are mainly three minor changes in this PR

  1. This PR adds vector map requirement "vm-02-02" to the autoware_requirement_set.json.
  2. Let validator mapping.stop_line.missing_regulatory_elements find stop lines that are referred with the refers role.
    1. This is because road_marking subtype regulatory elements refers to the stop line with the refers role.
  3. Fixed error in the validator_template.cpp

Related links

None

Tests performed

1. With autoware_test_utils/test_map/lanelet2_map.osm

autoware_test_utils/test_map/lanelet2_map.osm doesn't have a stop line that is referred with the refers role.
Hence, the following command should show [vm-02-02] Passed

ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator -m ./src/universe/autoware.universe/common/autoware_test_utils/test_map/lanelet2_map.osm -i ./src/autoware_tools/map/autoware_lanelet2_map_validator/autoware_requirement_set.json -o ./

2. With sample-planning-map/lanelet2_map.osm

sample-map-planning/lanelet2_map.osm has a lot of stop lines not been referred, but there are three stop lines that are referred from road_marking regulatory elements. Therefore, you should see 71 issues in [vm-02-02] after applying this PR, while you can see 74 issues in [vm-02-02] before applying this PR with the following command.

ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator -m ~/autoware_map/sample-map-planning/lanelet2_map.osm -i ./src/autoware_tools/map/autoware_lanelet2_map_validator/autoware_requirement_set.json -o ./

Notes for reviewers

Please try the above for testing. Testing other kinds of maps is also welcome.

Interface changes

None

Effects on system behavior

Stop lines being referred with the refers role will not be misjudged as errors.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review November 5, 2024 00:25
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.59%. Comparing base (ad0b811) to head (a10c20a).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
...ine/missing_regulatory_elements_for_stop_lines.cpp 16.66% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #143       +/-   ##
==========================================
+ Coverage   2.12%   27.59%   +25.47%     
==========================================
  Files        163       16      -147     
  Lines       9402      308     -9094     
  Branches     383      144      -239     
==========================================
- Hits         200       85      -115     
+ Misses      9045      155     -8890     
+ Partials     157       68       -89     
Flag Coverage Δ
differential 27.59% <16.66%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TaikiYamada4 TaikiYamada4 requested a review from soblin November 5, 2024 01:53
@TaikiYamada4 TaikiYamada4 merged commit 3c33924 into autowarefoundation:main Nov 5, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants