chore(autoware_lanelet2_map_validator): add requirement vm-02-02 to autoware_requirement_set #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are mainly three minor changes in this PR
autoware_requirement_set.json
.mapping.stop_line.missing_regulatory_elements
find stop lines that are referred with therefers
role.road_marking
subtype regulatory elements refers to the stop line with therefers
role.validator_template.cpp
Related links
None
Tests performed
1. With autoware_test_utils/test_map/lanelet2_map.osm
autoware_test_utils/test_map/lanelet2_map.osm doesn't have a stop line that is referred with the
refers
role.Hence, the following command should show
[vm-02-02] Passed
2. With sample-planning-map/lanelet2_map.osm
sample-map-planning/lanelet2_map.osm has a lot of stop lines not been referred, but there are three stop lines that are referred from
road_marking
regulatory elements. Therefore, you should see 71 issues in[vm-02-02]
after applying this PR, while you can see 74 issues in[vm-02-02]
before applying this PR with the following command.ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator -m ~/autoware_map/sample-map-planning/lanelet2_map.osm -i ./src/autoware_tools/map/autoware_lanelet2_map_validator/autoware_requirement_set.json -o ./
Notes for reviewers
Please try the above for testing. Testing other kinds of maps is also welcome.
Interface changes
None
Effects on system behavior
Stop lines being referred with the
refers
role will not be misjudged as errors.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.