Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rqt_diagnostic_graph_monitor): add missing dependency #149

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Nov 13, 2024

Description

Fix missing dependency of rqt_diagnostic_graph_monitor package.

Related links

None

Tests performed

  1. Build with --packages-up-to rqt_diagnostic_graph_monitor option
  2. Run rqt_diagnostic_graph_monitor

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@TetsuKawa TetsuKawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isamu-takagi isamu-takagi enabled auto-merge (squash) November 28, 2024 12:06
@isamu-takagi isamu-takagi self-assigned this Nov 28, 2024
@isamu-takagi isamu-takagi merged commit a7c02c8 into main Nov 28, 2024
29 checks passed
@isamu-takagi isamu-takagi deleted the fix/dependency-diag-graph-monitor branch November 28, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants