Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lanelet2_map_validator): change validation order in regulatory_elements_details #151

Conversation

TaikiYamada4
Copy link
Contributor

Description

This PR changes the order of validation in regulatory_elements_details.
The validator will first check whether there are empty attributes, and then will check the type of them are valid.

Thanks to this change the validator will NOT output two issues when the attribute type is wrong.

Related links

This bug was found through this PR #150.
Because the PR above cannot pass the colcon test in the CI, this PR has to go first.

Tests performed

Test the codes through

colcon test --event-handlers console_cohesion+ --packages-select autoware_lanelet2_map_validator

Notes for reviewers

Note that this change is mainly aimed to fix the bug found in the test made in PR #150.
I had to change test_regulatory_element_details.cpp too due to the changes in regulatory_element_details_for_traffic_lights.cpp and regulatory_element_details_for_crosswalks.cpp, but test_regulatory_element_details.cpp will be removed soon in PR #150.

Interface changes

None

Effects on system behavior

Since the validation changed, no redundant issues of "missing refers" will be gone when the refers type is only wrong.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TaikiYamada4 TaikiYamada4 merged commit 2e93ca1 into autowarefoundation:main Nov 14, 2024
32 checks passed
@TaikiYamada4 TaikiYamada4 deleted the fix/lanelet2_map_validator/regulatory_elements_details/change_validation_order branch November 14, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants