fix(lanelet2_map_validator): change validation order in regulatory_elements_details #151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the order of validation in
regulatory_elements_details
.The validator will first check whether there are empty attributes, and then will check the type of them are valid.
Thanks to this change the validator will NOT output two issues when the attribute type is wrong.
Related links
This bug was found through this PR #150.
Because the PR above cannot pass the
colcon test
in the CI, this PR has to go first.Tests performed
Test the codes through
Notes for reviewers
Note that this change is mainly aimed to fix the bug found in the test made in PR #150.
I had to change
test_regulatory_element_details.cpp
too due to the changes inregulatory_element_details_for_traffic_lights.cpp
andregulatory_element_details_for_crosswalks.cpp
, buttest_regulatory_element_details.cpp
will be removed soon in PR #150.Interface changes
None
Effects on system behavior
Since the validation changed, no redundant issues of "missing refers" will be gone when the refers type is only wrong.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.