-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lanelet2_map_validator): added issue codes #163
Merged
TaikiYamada4
merged 10 commits into
autowarefoundation:main
from
TaikiYamada4:feat/lanelet2_map_validator/alt_add_error_code
Nov 26, 2024
Merged
feat(lanelet2_map_validator): added issue codes #163
TaikiYamada4
merged 10 commits into
autowarefoundation:main
from
TaikiYamada4:feat/lanelet2_map_validator/alt_add_error_code
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
TaikiYamada4
requested review from
anhnv3991,
soblin,
Motsu-san,
SakodaShintaro and
YamatoAndo
as code owners
November 25, 2024 00:06
Signed-off-by: TaikiYamada4 <[email protected]>
Signed-off-by: TaikiYamada4 <[email protected]>
soblin
approved these changes
Nov 26, 2024
TaikiYamada4
added a commit
to TaikiYamada4/autoware_tools
that referenced
this pull request
Dec 5, 2024
* Added issue code processing Signed-off-by: TaikiYamada4 <[email protected]> * Revised tests for json processing Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for missing_regulatory_elements_for_crosswalks Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for regulatory_element_details_for_crosswalks Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for missing_regulatory_elements_for_stop_lines Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for missing_regulatory_elements_for_traffic_lights Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for regulatory_element_details_for_traffic_lights Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes to docs Signed-off-by: TaikiYamada4 <[email protected]> * Change issue_code_prefix to append_issue_code_prefix Signed-off-by: TaikiYamada4 <[email protected]> * Fixed merging mistake Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]>
TaikiYamada4
added a commit
that referenced
this pull request
Dec 5, 2024
…cing (#165) * Added valdiator missing_referrers_for_traffic_lights Signed-off-by: TaikiYamada4 <[email protected]> * Added validator traffic_light_facing Signed-off-by: TaikiYamada4 <[email protected]> * Added traffic_light_facing and missing_referrers_for_traffic_lights Signed-off-by: TaikiYamada4 <[email protected]> * Added new validators to README.md Signed-off-by: TaikiYamada4 <[email protected]> * Added test codes for traffic_light_facing and missing_referrers_for_traffic_lights Signed-off-by: TaikiYamada4 <[email protected]> * feat(lanelet2_map_validator): added issue codes (#163) * Added issue code processing Signed-off-by: TaikiYamada4 <[email protected]> * Revised tests for json processing Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for missing_regulatory_elements_for_crosswalks Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for regulatory_element_details_for_crosswalks Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for missing_regulatory_elements_for_stop_lines Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for missing_regulatory_elements_for_traffic_lights Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes for regulatory_element_details_for_traffic_lights Signed-off-by: TaikiYamada4 <[email protected]> * Added issue codes to docs Signed-off-by: TaikiYamada4 <[email protected]> * Change issue_code_prefix to append_issue_code_prefix Signed-off-by: TaikiYamada4 <[email protected]> * Fixed merging mistake Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]> * Changed to append_issue_code_prefix. Added test for TrafficLight.CorrectFacing-001 Signed-off-by: TaikiYamada4 <[email protected]> * Rearrange code structure Signed-off-by: TaikiYamada4 <[email protected]> * Fixed spelling mistakes Signed-off-by: TaikiYamada4 <[email protected]> * Fixed traffic_light_facing_procedure.svg Signed-off-by: TaikiYamada4 <[email protected]> * Fixed mistakes in document Signed-off-by: TaikiYamada4 <[email protected]> * Refine algorithm in traffic_light_facing.cpp Signed-off-by: TaikiYamada4 <[email protected]> * Shorten the data collection process, and updated the procedure svg Signed-off-by: TaikiYamada4 <[email protected]> * Use findUsages in missing_referrers_for_traffic_lights Signed-off-by: TaikiYamada4 <[email protected]> * Update map/autoware_lanelet2_map_validator/docs/traffic_light/missing_referrers_for_traffic_lights.md Co-authored-by: Mamoru Sobue <[email protected]> Signed-off-by: TaikiYamada4 <[email protected]> * style(pre-commit): autofix Signed-off-by: TaikiYamada4 <[email protected]> * Quit stocking all lanelets to collect traffic light regulatory elements Signed-off-by: TaikiYamada4 <[email protected]> --------- Signed-off-by: TaikiYamada4 <[email protected]> Co-authored-by: Mamoru Sobue <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds issue codes to the validator so that systems receiving the JSON output can process the issues much mechanically.
The issue codes are automatically generated by taking the upper snake case of the validator's name and remove the first
Mapping.
part.I also added the issue codes to the documents.
Related links
None
Tests performed
Updated the test codes to check that the
autoware_lanelet2_map_validator
outputs the correct issue codes, and confirmed thatcolcon test
passes.Normal validation like
will return lanelet2_validation_results.json like this.
Notes for reviewers
Order of the issues is changed in some test codes and documents so that they match with its number, but I believe the content isn't changed.
Interface changes
The output JSON also contains the issue_code.
Effects on system behavior
Except the output shows issue codes, none.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.