Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(spell-check): use awf dict #168

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Dec 5, 2024

Description

currently @xmfcx made https://github.com/autowarefoundation/autoware-spell-check-dict. so autoware_tools should use this one.

Related links

this is part of #11 but it needs time to solve conflict

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r
Copy link
Member

cspell is failing so we might need to fix that first.

@mitsudome-r mitsudome-r merged commit 5197af4 into main Dec 5, 2024
31 checks passed
@mitsudome-r mitsudome-r deleted the feat/use_awf_spell_check branch December 5, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants