Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lanelet2_map_validator): automate test code compilation #173

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Dec 13, 2024

Description

This PR renews the compilation approach so that the contributors doesn't have to declare their test codes in the CMakeLists.txt file.

In addition, the test codes are also categorized as same as the ones in the src directory.

Related links

None

Tests performed

  1. Tested that clean building works perfectly.
  2. Tested that colcon test works perfectly
  3. Tested that ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator works perfectly with sample_map.osm

Notes for reviewers

Renewed in here #183

Interface changes

None

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TaikiYamada4 TaikiYamada4 changed the title Chore/lanelet2 map validator/automate test code compilation chore(lanelet2 map validator): automate test code compilation Dec 13, 2024
@TaikiYamada4 TaikiYamada4 changed the title chore(lanelet2 map validator): automate test code compilation chore(lanelet2_map_validator): automate test code compilation Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant