Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lanelet2_map_validator): add validator to check whether intersection lanelets have valid turn_direction tags #186

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TaikiYamada4
Copy link
Contributor

Description

This PR adds a validator mapping.intersection.turn_direction_tagging that checks whether lanelets in intersections have turn_direction tags and their values are left, right, or straight.

In short, this PR adds the following implementation.

  • New validator mapping.intersection.turn_direction_tagging that detects lanelets that belong to intersections but don't have a valid turn_direction tag.
  • A test code for mapping.intersection.turn_direction_tagging.
  • A document for mapping.intersection.turn_direction_tagging.
  • Added mapping.intersection.turn_direction_tagging to autoware_requirement_set.json

How was this PR tested?

  1. Confirmed that colcon test --packages-select autoware_lanelet2_map_validator --event-handlers console_cohesion+ passes.
  2. Confirmed that the following command shows no mistakes against several lanelet2 maps I have.
ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator -p mgrs -m <PATH_TO_sample_map.osm> -i <PATH_TO_autoware_requirement_set.json> -o ./

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: TaikiYamada4 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants