-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoware msg bag converter #48
Conversation
5a9d9c1
to
c57ebd5
Compare
9348e2f
to
59c34bd
Compare
bcfaad5
to
6118558
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! I think it's basically fine.
However, let's wait until get approve from mitsudome-san before merging.
type: git | ||
url: https://github.com/autowarefoundation/autoware_common.git | ||
version: main | ||
core/external/autoware_auto_msgs: # TODO(mfc): Remove when autoware_msgs is merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is okay to delete the comment as it seems unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed with the following commit hash
4617d5e
<package format="3"> | ||
<name>autoware_msg_bag_converter</name> | ||
<version>0.1.0</version> | ||
<description>TODO: Package description</description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably make a change because there is still a TODO left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed with the following commit hash
95a2270
Since there is a dependency on autoware_auto_msg, cut it out as a separate branch instead of putting it in this repository |
Description
Added tool to convert bag containing autoware_auto_msg to autoware_msg
Related links
Tests performed
colcon test
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.