Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoware msg bag converter #48

Closed
wants to merge 8 commits into from

Conversation

hayato-m126
Copy link

@hayato-m126 hayato-m126 commented Jun 13, 2024

Description

Added tool to convert bag containing autoware_auto_msg to autoware_msg

Related links

Tests performed

colcon test

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@hayato-m126 hayato-m126 force-pushed the feat/add-autoware-msg-bag-converter branch from 9348e2f to 59c34bd Compare June 13, 2024 07:30
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I think it's basically fine.
However, let's wait until get approve from mitsudome-san before merging.

type: git
url: https://github.com/autowarefoundation/autoware_common.git
version: main
core/external/autoware_auto_msgs: # TODO(mfc): Remove when autoware_msgs is merged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is okay to delete the comment as it seems unnecessary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed with the following commit hash
4617d5e

<package format="3">
<name>autoware_msg_bag_converter</name>
<version>0.1.0</version>
<description>TODO: Package description</description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably make a change because there is still a TODO left.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed with the following commit hash
95a2270

@hayato-m126
Copy link
Author

Since there is a dependency on autoware_auto_msg, cut it out as a separate branch instead of putting it in this repository

@hayato-m126 hayato-m126 deleted the feat/add-autoware-msg-bag-converter branch June 25, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants