Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_logging_level_configure_rviz_plugin): update logger configuration for behavior path planner dynamic obstacle avoidance #50

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

add logger configuration for behavior path planner dynamic obstacle avoidance

Tests performed

change logger level in rviz panel
image

output debug level log in the terminal
image

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@xmfcx xmfcx closed this Jun 17, 2024
@xmfcx xmfcx reopened this Jun 17, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Jun 17, 2024

I've fixed the CI issue with the build-and-test-differential workflow:

So I'm updating this to main branch.

You may proceed to merge it if you are alright with the PR.

Also the codeowners are updated, at least one approval from them is required.

If you are experienced in this package, you may add yourself to package maintainer list too.

@kyoichi-sugahara
Copy link
Contributor Author

@xmfcx

I've fixed the CI issue with the build-and-test-differential workflow:

Thank you so much always!!! I really appreciate 😍

Also the codeowners are updated, at least one approval from them is required.

Ok I will handle it, thanks!

@kyoichi-sugahara kyoichi-sugahara merged commit 63720f5 into main Jun 18, 2024
21 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/update_logger_configuration_dynamic_obstacle_avoidance branch June 18, 2024 02:41
xtk8532704 pushed a commit that referenced this pull request Jun 19, 2024
…e avoidance (#50)

Signed-off-by: kyoichi-sugahara <[email protected]>
Co-authored-by: M. Fatih Cırıt <[email protected]>
Signed-off-by: temkei.kem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants