Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(path_optimizer): rename package name and fix trajectory visualizer #98

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Aug 16, 2024

Description

obstacle_avoidance_planner -> path_optimizer

related to:
https://github.com/orgs/autowarefoundation/discussions/4741

fix some tools to work

image

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <[email protected]>
@kosuke55
Copy link
Contributor Author

@takayuki5168
could you please approve this PR?

@kosuke55
Copy link
Contributor Author

@TakaHoribe @satoshi-ota please approve

@kosuke55 kosuke55 enabled auto-merge (squash) August 21, 2024 11:08
Copy link

@sasakisasaki sasakisasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps motion_velocity_smoother in this line is not used in the recent Autoware. As far as I see, velocity_smoother is maybe the right one.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Sep 2, 2024

@sasakisasaki
thanks! but this PR is for rename of path_optimizer, so I would like to it as it is.

@yhisaki yhisaki self-requested a review September 2, 2024 12:23
Copy link
Contributor

@yhisaki yhisaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In trajectory_visualizer.py Line 332-333.

        if self.update_traj_final:
            self.im10.set_data([0], [self.localization_vx])
            self.im11.set_data([0], [self.vehicle_vx])

@kosuke55 kosuke55 changed the title refactor(path_optimizer): rename package name refactor(path_optimizer): rename package name and fix trajectory visualizer Sep 2, 2024
@kosuke55 kosuke55 merged commit 0084c25 into main Sep 3, 2024
19 checks passed
@kosuke55 kosuke55 deleted the fix/path_optimizer branch September 3, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants