Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add robosense Bpearl and Helios Lidar launch files for users #102

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

ismetatabay
Copy link
Member

Description

This PR adds launch files and updates the nebula_node_container launch for the Robosense BPearl and Helios Lidar sensors.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ismetatabay ismetatabay force-pushed the feat/robosense-launch branch from 4e6ac98 to 34d4d0b Compare August 20, 2024 11:29
@ismetatabay ismetatabay marked this pull request as ready for review August 20, 2024 11:31
@ismetatabay ismetatabay requested review from knzo25 and drwnz August 20, 2024 11:31
@ismetatabay ismetatabay self-assigned this Aug 20, 2024
@knzo25
Copy link
Contributor

knzo25 commented Aug 27, 2024

I tested that the default pipeline works as before (autoware replay tutorial)

Also I tested the new files with:

ros2 launch common_sensor_launch robosense_Helios.launch.xml vehicle_mirror_param_file:=install/sample_vehicle_description/share/sample_vehicle_description/config/mirror.param.yaml  front_overhang
ros2 launch common_sensor_launch robosense_Bpearl.launch.xml vehicle_mirror_param_file:=install/sample_vehicle_description/share/sample_vehicle_description/config/mirror.param.yaml

*Note: I hardcoded vehicle dimensions to test this

@ismetatabay ismetatabay force-pushed the feat/robosense-launch branch from 692feb0 to 56727b9 Compare September 2, 2024 07:47
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx merged commit fcc7cde into autowarefoundation:main Sep 3, 2024
8 of 9 checks passed
@ismetatabay ismetatabay deleted the feat/robosense-launch branch September 3, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants