Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nebula_node_container): make launchers work with Nebula v0.2.0 #106

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

mojomex
Copy link
Contributor

@mojomex mojomex commented Sep 24, 2024

Description

Supersedes

This PR makes the launcher changes necessary for the Nebula v0.2.0 release to work.
This PR is part of a 3-PR group that has to be merged in tandem. The other two are:

See

I will merge all PRs in tandem once all of them get approved and have passing CI.
Please do not merge them independently.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mojomex mojomex changed the title chore(nebula_node_container): make launchers work with Nebula v0.2.0 chore(nebula_node_container)!: make launchers work with Nebula v0.2.0 Sep 24, 2024
@mojomex mojomex changed the title chore(nebula_node_container)!: make launchers work with Nebula v0.2.0 chore(nebula_node_container): make launchers work with Nebula v0.2.0 Sep 24, 2024
@mojomex
Copy link
Contributor Author

mojomex commented Sep 25, 2024

(build-and-test-differential CI is failing because git diff did not find any changed files, not because it didn't build)

@xmfcx xmfcx force-pushed the chore/upgrade-to-nebula-v0.2.0 branch from 0b9af3f to c984afb Compare October 3, 2024 10:53
@xmfcx
Copy link
Contributor

xmfcx commented Oct 3, 2024

Rebased to test with latest main. Otherwise it won't work.

Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xmfcx xmfcx merged commit 3439eb3 into main Oct 3, 2024
10 of 11 checks passed
@xmfcx xmfcx deleted the chore/upgrade-to-nebula-v0.2.0 branch October 3, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants