Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change pointcloud preprocess output from base_link to sensor_frame #90

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Feb 22, 2024

Description

  • In the current preprocessing, sensor output frame is base_link so that the latter process can not get from which the pointcloud is derived
  • This PR enable to publish preprocessed pointclouds with sensor frame

image

As you know this will increase frame conversion overhead slightly, but it seems that it does not affect total performance so much.

image

Related links

JIRA ticket: TIER IV INTERNAL LINK

Tests performed

Tested with sample rosbag, and X2 bench(TIER IV).

ringoutlier filter procesing time varied from 6.2ms to 7.1ms.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <[email protected]>
@YoshiRi YoshiRi force-pushed the feat/use_sensorframe_in_lidar_preprocessinsg_output branch from a7c4b28 to 4a53f51 Compare February 22, 2024 02:30
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
It has not been confirmed by running.

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Feb 22, 2024

@yukkysaito
It has confirmed in both my computer and X2 test bench, but not in autonomous driving scene.

@YoshiRi YoshiRi merged commit c21d67e into main Feb 26, 2024
9 of 10 checks passed
@YoshiRi YoshiRi deleted the feat/use_sensorframe_in_lidar_preprocessinsg_output branch February 26, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants