Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common_sensor_launch, pointcloud_preprocessor): change pointcloud interface to synchronized pointclouds #91

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Mar 1, 2024

Description

Related with https://github.com/orgs/autowarefoundation/discussions/4158, this PR tries to change sensing lidar pointcloud interface from topic before concatenation to topic after time synchronization.

This PR must merged after universe feature: autowarefoundation/autoware.universe#6525.

Related links

Tests performed

Tested with Lsim with sample rosbag.
Localization also worked.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I confirmed that

  • The localization worked in the logging_simulator tutorial either with using /sensing/lidar/top/pointcloud or /sensing/lidar/concatenated/pointcloud. (localization preprocessing nodes attched to pointcloud_container)
  • The localization also worked when using /sensing/lidar/top/pointcloud_before_sync and attaching the localization preprocessing nodes to /sensing/lidar/top/pointcloud_preprocessor/pointcloud_container

@YoshiRi YoshiRi merged commit bfe2260 into main Mar 4, 2024
9 of 10 checks passed
@YoshiRi YoshiRi deleted the feat/change_pointcloud_interface_to_synched_pcs branch March 4, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants