Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(single_lidar_common_launch): load from parameter #3

Conversation

@vividf
Copy link
Contributor Author

vividf commented Oct 22, 2024

@mojomex @beginningfan could you review this, thanks

@beginningfan
Copy link
Collaborator

beginningfan commented Oct 25, 2024

@vividf Thanks for your work. LGTM.
Actually, when I created this repository, I had a lot of confusion about the config of sensor_kit and individual_marams. At that time, I directly used the config of sensor_kit. However, now autoware.launch.xml has always been individual_marams. If it continues to be individual_marams, we also need to add a default config of single_lidar_sensor_kit in the autoware_individual_params repository to launch single_lidar_sensor_kit successfully. Can you please complete this task?

@cyn-liu
Copy link

cyn-liu commented Oct 25, 2024

@vividf Thanks for your work. LGTM.
I will review this PR later.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change

    nodes.append(
        ComposableNode(
            package="pointcloud_preprocessor",
            plugin="pointcloud_preprocessor::CropBoxFilterComponent",
            name="crop_box_filter_self",

to

nodes.append(
        ComposableNode(
            package="autoware_pointcloud_preprocessor",
            plugin="autoware::pointcloud_preprocessor::CropBoxFilterComponent",
            name="crop_box_filter_self",

Similar modifications should also be made to other related nodes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout in vscode looks fine
image

Also, I didn't modify this part of the code

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I update to the latest Autoware, there will be an error when compiling that there is no package pointcloud_preprocessor, You must modify it to autoware_pointcloud_preprocessor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks, I didn't see the changes you mentioned.
I thought it was a layout issue.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyn-liu these are fixed in 1e2573d

@vividf vividf requested a review from cyn-liu November 7, 2024 07:57
@vividf
Copy link
Contributor Author

vividf commented Nov 7, 2024

@cyn-liu If everything works well, please merge this PR :)
Thanks!

@beginningfan beginningfan merged commit f649db1 into autowarefoundation:main Nov 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants