[chain] Introduce Multi-Actions and Outputs in Transactions #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wlawt
commented
Apr 25, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wlawt
force-pushed
the
multi-action-support
branch
2 times, most recently
from
c6ab96d
to
d4fa834
Compare
wlawt
commented
Apr 25, 2024
| @@ -432,19 +432,19 @@ var _ = ginkgo.Describe("[Tx Processing]", func() { | |||
| // read: 2 keys reads, 1 had 0 chunks | |||
| // allocate: 1 key created with 1 chunk | |||
| // write: 2 keys modified (new + old) | |||
| transferTxConsumed := fees.Dimensions{187, 7, 12, 25, 26} | |||
| transferTxConsumed := fees.Dimensions{191, 7, 12, 25, 26} | |||
There was a problem hiding this comment.
updated back to 191 because we do p.PackInt(len(t.Actions)) which is 4 bytes
wlawt
force-pushed
the
multi-action-support
branch
13 times, most recently
from
ca77bb4
to
fbe2b9e
Compare
wlawt
commented
May 1, 2024
wlawt
force-pushed
the
multi-action-support
branch
6 times, most recently
from
7bb262b
to
3979353
Compare
wlawt
commented
May 3, 2024
wlawt
commented
May 3, 2024
wlawt
force-pushed
the
multi-action-support
branch
from
395c79c
to
43d77e2
Compare
Patrick354
approved these changes
May 10, 2024
* include r.Outputs size in calculation above * fix packing of Outputs for each Action
* remove err from Action * mock gen * add more TODOs * add context on why revert is better * add back error * cleanup interface * cleanup tx loop * update error marshaling * update transfer op * cleaning up access * finish tokenvm * update mocks * fix programs * update create order * cleanup cmd program * backend.go compiles * more cleanup * morpheusvm integration passing * fix tokenvm integration * add nolint * require lint --------- Co-authored-by: Patrick O'Grady <[email protected]>
* remove LID definition * remove optional packer * update cli * update heap * eheap + emap * making progress on morpheusvm * cleanup load test error * tokenvm actions * update token-cli * update token-feed + token-faucet * update token-wallet * more progress in tokenvm * update token storage * use id const * update programs * unit tests passing * remove consts form simulator * fix lint * pass integration tests * integration test passing * reduce size of digest * fix load test * e2e lint * reuse nodes * reuse nodes * fix lint * run gci
* add key validity check to Keys set * cleanup state key validity checking * reviewed chain/transaction * cli changes * add multi-send example to morpheus * cleanup tokenvm * remove heap casting * fix program execute * fix return * cleanup var names * unify error * update fetcher tests * remove unnecessary conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #335 , #359
Overview
This PR introduces the ability to specify multiple actions within a single transaction. We limit the number of actions that can be specified within a transaction using
MaxActionsPerTx.Furthermore, this PR introduces the ability to specify multiple outputs in
Result. This lays the groundwork to enable outputting multiple Warp messages in an Action/Transaction.Review Guide
chain/transaction.go- Core logic to handle multiple actionschain/result.go- Enabling multiple outputsTODO
Ruleto limit number ofActionsperTransactionActionID(hash(txID, actionIndex))Tests