Add script for installing foundry #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
changed the title
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
gwen917 and
bernard-avalabs
as code owners
geoff-vball
force-pushed
the
gstuart/install-foundry-script
branch
from
9c724b1 to
2ba9679
Compare
scripts/install_foundry.sh
Outdated
|
|
||
| set -e | ||
|
|
||
| FOUNDRY_VERSION=v0.1.0 |
There was a problem hiding this comment.
should we set this in versions.sh?
There was a problem hiding this comment.
IMO we should only use versions.sh for a version that is needed in more than one place. Adding indirectly here only increases complexity.
This reverts commit 6f97f73.
minghinmatthewlam
previously approved these changes
Nov 27, 2023
gwen917
reviewed
Nov 27, 2023
minghinmatthewlam
previously approved these changes
Nov 27, 2023
cam-schultz
reviewed
Nov 28, 2023
michaelkaplan13
approved these changes
Nov 28, 2023
gwen917
approved these changes
Nov 28, 2023
|
@michaelkaplan13 No we haven't added the ARM64 binaries yet. |
Updated https://github.com/ava-labs/foundry/releases/tag/v0.1.0 with ARM64 binaries. |
minghinmatthewlam
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Unifies Dockerfile and github CI to both install foundry in the same manner from our forked repo.
How this works
How this was tested
How is this documented