Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native Token Bridge #40
Native Token Bridge #40
Changes from 219 commits
799c289
a393c5b
275c9c9
97d4cf1
99df7ee
31120c7
36465ed
f7ee05a
91b83ae
6d271c5
93805ff
5ddae27
121d835
8ceb73e
060be4e
7b45964
95248f9
df2bba8
96f6d90
0602743
1dd2858
ff56992
a64ec01
1c365d6
000e4a5
4b69e18
db52a48
9bbf156
4ec83d3
ece2e5b
4d00724
6ca248f
f9e7710
d010484
52e2d3a
ba18e5b
c9c2cc9
9c2c700
03a473f
3f36fb3
eeecf1f
3456f8b
7cda837
0440efd
fb56ad6
02b9045
ce45fb4
c135025
7a31baa
fc73351
7eacec7
2496979
e42884f
d94a736
d60d97b
2f5f093
30be639
c1574ea
4527054
9927e9f
4516a44
a686b54
f3cc0ec
b6d628f
9863960
a297918
5afcbef
27798b7
fa42e80
549361a
80c4dbd
14b11b0
06aee49
ea0ed4c
3ccf5e3
28adeb3
722d5cf
af1007a
b10f970
72d42e4
b51443f
228646b
ada88f2
271a8a7
293570c
88f7e84
9e8ac53
2e9c6e1
809f344
072a697
7187ac2
14d3b69
6111e86
9934478
12adf80
3bc64c0
4e80995
0271061
d784d24
2cb7180
406c9b3
c8ed6ae
672dc88
b5356d6
c3c0931
48490ea
4c8d7d3
aad4373
720a2d8
40ebc58
849e938
472f62e
8bc0717
01860a5
0004f59
b684f53
19c921e
5b28388
16c5d33
4422632
526231d
1caf678
0bbb1b7
b9fea48
6346cca
6f207da
d78ab64
581f3d7
635ff27
f9305a9
1d9fe93
49a2cb8
bf1b852
cdfc623
01436a4
2d8365a
471b66a
5447a4e
a67ca77
ea41649
045bfc2
c19ddf6
1584c90
39f570c
c471cef
b0445f7
25fb790
8cfde6b
ebdb01d
a1c08bb
d723ef2
a4c11b0
ae0e397
12b9702
4bed474
22e5cfc
6380773
30519d8
69c3fab
5e0c541
cd9a06f
41e90f5
f0d5857
2269287
00faa2c
a1f538a
1276b27
fc1f418
0d881e1
737e890
3a46ee8
0742ead
64571c4
68a322d
9ba19e3
dd0674e
3fe7e0f
a4dcbbd
2af7b11
eda62d6
f96024d
6162309
91a265d
cef97d7
2355865
4a6059a
95fba13
f8d720d
8a793db
1e66e26
f606605
8b3e203
354b53a
0a3e4ff
250ef1a
9daf35a
039b3d9
162a701
84098a2
c36aa4b
d1cf827
93dab58
21ed29a
cc0cafe
414cb5d
a341da3
787f0ef
7f6e0fe
07ed07d
b73d38f
9d56c4f
c0aaa50
c217139
712538c
ca029ab
c6fbd80
2ab9ec8
2b30495
1e09c2e
2f10597
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Calling out that we should use
TeleporterUpgradable
here so that we can use theonlyAllowedTeleporter
modifier. If we want to do this in a later PR, lets create an issue for it now. 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented it in this commit, but reverted the changes because the e2e setup doesn't currently deploy the registry, and I didn't want to go fooling around in there until the
general-e2e
PR is merged.Should we have a general ticket for all the cross-chain applications to use the registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconding this. I'm in favor of creating a followup ticket to add registry and upgrade support to this set of contracts so that we don't further bloat this PR's scope.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with above, lets create a new issue for it and defer