N-06 Magic Numbers #610
Merged
N-06 Magic Numbers #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
iansuvak,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
iansuvak
approved these changes
Oct 18, 2024
cam-schultz
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
LGTM. I was thinking of ways to eliminate the duplicate constant, but couldn't come up with anything that didn't muddy the rewards calculator interface. Since delegator fees are handled exclusively by the PoSValidatorManager, there's reason to have the const in both places anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes magic numbers
I think changing 100 to a constant when dealing with percentages is more confusing than using the number, but let me know if anyone has a differing opinion here.