Enforce uint64max weights #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
richardpringle,
geoff-vball,
bernard-avalabs and
michaelkaplan13
iansuvak
approved these changes
Nov 19, 2024
| @@ -346,7 +346,7 @@ func InitializeNativeTokenValidatorSet( | |||
| validationIDs = append(validationIDs, subnetInfo.SubnetID.Append(uint32(i))) | |||
| } | |||
|
|
|||
| Expect(initialValidatorCreatedEvent.Weight).Should(Equal(new(big.Int).SetUint64(nodes[0].Weight))) | |||
| Expect(initialValidatorCreatedEvent.Weight).Should(Equal(nodes[0].Weight)) | |||
There was a problem hiding this comment.
it's a nice side effect that these are now primitive types
geoff-vball
reviewed
Nov 20, 2024
TBH, I think linking to the ACP-77 spec sufficiently documents this. I don't think it'd be helpful to explicitly document this data type here over the data type of any other field. Note that we do document how this limit affects staked value for the PoS case: https://github.com/ava-labs/teleporter/blob/main/contracts/validator-manager/README.md?plain=1#L72 |
geoff-vball
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Enforces that validator weights cannot exceed uint64max, which is the validator weight cap enforced on the P-Chain.
How this works
Adds an explicit check in
_initializeValidatorRegistration. Note that the churn tracker also enforces this bound, but an explicit check is more readable and easier to test functionally.Also updates all variables/fields/params that represent weights to use
uint64How this was tested
New unit test
How is this documented
N/A