Fix Integration Test and Pin Foundry #85
Conversation
michaelkaplan13
requested review from
cam-schultz,
minghinmatthewlam,
gwen917,
geoff-vball and
bernard-avalabs
as code owners
| echo "export PATH=\"$PATH:/$HOME/.foundry/bin\"">> ~/.bashrc && \ | ||
| source ~/.bashrc && \ | ||
| export PATH=$PATH:$HOME/.foundry/bin:$HOME/.cargo/bin && \ | ||
| foundryup | ||
| foundryup --version nightly-70d00222c2ef74fc484b8d98c5705d131ab31871 |
There was a problem hiding this comment.
I believe the foundry nightly builds are regularly pruned, but some stick around longer tem. Do we know if this build is one of the long term ones?
There was a problem hiding this comment.
Good point. We might want to use the oct 2 release which is 5be158b
There was a problem hiding this comment.
That's a great call out. If foundry isn't going have official release versions, I'd be a fan of keeping our own "stable" build hosted some where to ensure availability.
Created an issue to track it here: #88
The release used in this branch was just published today, so I think it will be okay to use for at least the short term.
There was a problem hiding this comment.
This should be fine if we merge in #84, which will make it easy to spot the reason for failure if this version gets pruned.
There was a problem hiding this comment.
Jokes on us, this version has already been pruned 🙃
Why this should be merged
Updates the integration tests to work with the latest breaking Foundry changes, and manually pins the foundry installation to a specific commit.
How this works
Foundry is installed by first fetching the script at https://raw.githubusercontent.com/foundry-rs/foundry/70d00222c2ef74fc484b8d98c5705d131ab31871/foundryup/install, which previously was not pinned to a commit. That script itself fetches another file from the main branch of their repo, which is worked around by using
sedto again pin that URL to the same commit. Finally,foundryup --versionis used to install a specific release binary.How this was tested
CI
How is this documented
N/A