rename chainID to blockchainID #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
gwen917 and
bernard-avalabs
as code owners
cam-schultz
previously approved these changes
Nov 28, 2023
| @@ -38,7 +38,7 @@ type MessageProtocolConfig struct { | |||
| } | |||
| type SourceSubnet struct { | |||
| SubnetID string `mapstructure:"subnet-id" json:"subnet-id"` | |||
| ChainID string `mapstructure:"chain-id" json:"chain-id"` | |||
| BlockchainID string `mapstructure:"blockchain-id" json:"blockchain-id"` | |||
There was a problem hiding this comment.
We'll have to update https://github.com/ava-labs/teleporter/blob/main/docker/relayerConfigTemplate.json to match the new config options. It looks like that slipped through the cracks of the other PR.
minghinmatthewlam
previously approved these changes
Nov 29, 2023
geoff-vball
dismissed stale reviews from minghinmatthewlam and cam-schultz
via
b87138e
cam-schultz
previously approved these changes
Nov 29, 2023
Signed-off-by: Geoff Stuart <[email protected]>
geoff-vball
dismissed stale reviews from bernard-avalabs and cam-schultz
via
1dfecd9
…/awm-relayer into gstuart/chainID-to-blockchainID
cam-schultz
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
chainID usually refers to an ethereum chainID, which is set in the chain genesis. This is distinct from blockchainID, which uniquely identifies a subnet on Avalanche, and is the hash of the P-Chain tx that creates the blockchain. We have used chainID in many places that should be blockchainID, so this PR looks to disambiguate them.
Note: chainID always appears as a *big.Int or uint256, whereas blockchainID is a [32]byte.
Related Teleporter PR ava-labs/icm-contracts#156
closes #70
How this works
How this was tested
How is this documented