Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RelTh file check for nans [com1] #887

Merged
merged 2 commits into from
Aug 9, 2023
Merged

RelTh file check for nans [com1] #887

merged 2 commits into from
Aug 9, 2023

Conversation

awirb
Copy link
Contributor

@awirb awirb commented Jul 19, 2023

check if nans in relTh file and throw error if so

@awirb awirb requested a review from fso42 July 19, 2023 06:25
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (bf0c24e) 75.17% compared to head (d8676a0) 75.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #887   +/-   ##
=======================================
  Coverage   75.17%   75.18%           
=======================================
  Files          62       62           
  Lines       13833    13837    +4     
=======================================
+ Hits        10399    10403    +4     
  Misses       3434     3434           
Files Changed Coverage Δ
avaframe/com1DFA/com1DFA.py 92.54% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fso42 fso42 added enhancement New feature or request bug Something isn't working labels Aug 7, 2023
@fso42 fso42 added this to the Version 1.6 milestone Aug 7, 2023
@fso42 fso42 self-assigned this Aug 8, 2023
@fso42 fso42 changed the title RelTh file check for nans RelTh file check for nans [com1DFA] Aug 8, 2023
@fso42 fso42 changed the title RelTh file check for nans [com1DFA] RelTh file check for nans [com1] Aug 8, 2023
  - add data for relTh nan check in file
@codeclimate
Copy link

codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit d8676a0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.1% (0.0% change).

View more on Code Climate.

@fso42 fso42 merged commit f16bc83 into master Aug 9, 2023
@fso42 fso42 deleted the relNans branch August 9, 2023 07:16
fso42 pushed a commit that referenced this pull request Aug 14, 2023
* check for nans in relThFile in com1DFA

  - add data for relTh nan check in file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants