Permission check should be done before requesting location updates

mrmans0n#277
avianey · Feb 13, 2020 · afbe3ca · afbe3ca
1 parent bfefb04
commit afbe3ca
Showing 1 changed file with 12 additions and 11 deletions.
diff --git a/...ary/src/main/java/io/nlopez/smartlocation/location/providers/LocationManagerProvider.java b/...ary/src/main/java/io/nlopez/smartlocation/location/providers/LocationManagerProvider.java
@@ -48,18 +48,19 @@ public void start(OnLocationUpdatedListener listener, LocationParams params, boo
 
         Criteria criteria = getProvider(params);
 
-        if (singleUpdate) {
-            if (ActivityCompat.checkSelfPermission(mContext, Manifest.permission.ACCESS_FINE_LOCATION)
-                    != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(mContext,
-                    Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
-                logger.i("Permission check failed. Please handle it in your app before setting up location");
-                // TODO: Consider calling ActivityCompat#requestPermissions here to request the
-                // missing permissions, and then overriding onRequestPermissionsResult
-                // to handle the case where the user grants the permission. See the documentation
-                // for ActivityCompat#requestPermissions for more details.
+        if (ActivityCompat.checkSelfPermission(mContext, Manifest.permission.ACCESS_FINE_LOCATION)
+                != PackageManager.PERMISSION_GRANTED && ActivityCompat.checkSelfPermission(mContext,
+                Manifest.permission.ACCESS_COARSE_LOCATION) != PackageManager.PERMISSION_GRANTED) {
+            logger.i("Permission check failed. Please handle it in your app before setting up location");
+            // TODO: Consider calling ActivityCompat#requestPermissions here to request the
+            // missing permissions, and then overriding onRequestPermissionsResult
+            // to handle the case where the user grants the permission. See the documentation
+            // for ActivityCompat#requestPermissions for more details.
 
-                return;
-            }
+            return;
+        }
+
+        if (singleUpdate) {
             locationManager.requestSingleUpdate(criteria, this, Looper.getMainLooper());
         } else {
             locationManager.requestLocationUpdates(