work around shrinked resources #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsvoronin
changed the title
dsvoronin
changed the title
dsvoronin
force-pushed
the
shrinked-res-case
branch
from
6006415 to
4739800
Compare
sboishtyan
reviewed
Feb 5, 2020
sboishtyan
reviewed
Feb 5, 2020
|
|
||
| ### Dynamically referenced resources | ||
|
|
||
| You can see in `PageObjectTest`, that we referenced `R.layout.page_object_1`, dynamically creating layout.\ |
There was a problem hiding this comment.
Enabled shrinkResourses delete resourses referenced only from tests.
Example in PageObjectTest.
There was a problem hiding this comment.
left as it was, i can hardly parse new variant
dsvoronin
force-pushed
the
shrinked-res-case
branch
from
b1d5147 to
8933cf5
Compare
dsvoronin
commented
Feb 5, 2020
| tools:keep="@layout/page_object*"/> | ||
| ``` | ||
|
|
||
| ### Try latest stable version of R8 |
There was a problem hiding this comment.
"Already has a mapping"
eugene-krivobokov
approved these changes
Feb 5, 2020
| tools:keep="@layout/page_object*"/> | ||
| ``` | ||
|
|
||
| ### Try latest stable version of R8 |
There was a problem hiding this comment.
the latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.