-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1124 | Option to add and view Colors for Report Card removed! #1195
Conversation
@ombhardwajj the issue says remove colors only for standard report cards. It looks like you have completely removed colors. |
Look for the question "Is standard report card" |
@vinayvenu , the issue says "Dont provide option to set colors" therefore If I am not wrong we had to remove the colour picker. I've removed it and added back all other stuff I had removed in the last commit. Please have a look! |
@ombhardwajj not sure if I was clear enough last time. The color and color picker are not required if and only if the user switches on the option "Is Standard Report Card?" |
@vinayvenu I finally understood what was wanted ! I have modified the code. Now the option to set colors disappears only for standard report cards. |
@ombhardwajj the changes look good. Some changes before I merge this
|
5bbed78
to
df8b7b9
Compare
@vinayvenu , I have squashed all the 3 commits and followed the commit format # | in the title of this PR. |
Merged. Thanks |
This PR fixes #1124 . Option to add and view colours for Report Card removed!