Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1124 | Option to add and view Colors for Report Card removed! #1195

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

ombhardwajj
Copy link
Contributor

This PR fixes #1124 . Option to add and view colours for Report Card removed!
CRC
ORC
VRC

@vinayvenu
Copy link
Member

@ombhardwajj the issue says remove colors only for standard report cards. It looks like you have completely removed colors.

@vinayvenu
Copy link
Member

Look for the question "Is standard report card"

@ombhardwajj
Copy link
Contributor Author

ombhardwajj commented Apr 15, 2024

col1 col2

@vinayvenu , the issue says "Dont provide option to set colors" therefore If I am not wrong we had to remove the colour picker. I've removed it and added back all other stuff I had removed in the last commit. Please have a look!

@vinayvenu
Copy link
Member

@ombhardwajj not sure if I was clear enough last time. The color and color picker are not required if and only if the user switches on the option "Is Standard Report Card?"

@ombhardwajj
Copy link
Contributor Author

ombhardwajj commented Apr 16, 2024

rclist nstdrc stdrc @vinayvenu I finally understood what was wanted ! I have modified the code. Now the option to set colors disappears only for standard report cards.

@vinayvenu
Copy link
Member

@ombhardwajj the changes look good. Some changes before I merge this

  1. Can you squash all three commits to one so it is easier to understand
  2. Follow the commit message guidelines here - https://avni.readme.io/docs/commit-guidelines

@ombhardwajj ombhardwajj changed the title Option to add and view Colors for Report Card removed! #1124 | Option to add and view Colors for Report Card removed! Apr 16, 2024
@ombhardwajj ombhardwajj changed the title #1124 | Option to add and view Colors for Report Card removed! Option to add and view Colors for Report Card removed! Apr 16, 2024
@ombhardwajj ombhardwajj changed the title Option to add and view Colors for Report Card removed! #1124 | Option to add and view Colors for Report Card removed! Apr 16, 2024
@ombhardwajj
Copy link
Contributor Author

ombhardwajj commented Apr 16, 2024

@vinayvenu , I have squashed all the 3 commits and followed the commit format # | in the title of this PR.

@vinayvenu vinayvenu merged commit 329cd6d into avniproject:master Apr 17, 2024
@vinayvenu
Copy link
Member

Merged. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dont provide option to set colors for standard report cards since they are hardcoded
2 participants