Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only process those Glific FlowResults which has "registration_flow_complete" set to "Yes" #102

Closed
Tracked by #24
himeshr opened this issue Oct 27, 2023 · 5 comments
Assignees

Comments

@himeshr
Copy link

himeshr commented Oct 27, 2023

In Glific, Flow_results with same ID are saved multiple times to BigQuery Flow_results table.
This results in partially completed flows also to be returned in the BigQuery SQL Query response.
Only process those Glific FlowResults which has "registration_flow_complete" set to "Yes", which is an indicator that Contact has completed the entire flow.

Sample flow_results results column excerpts

{...
      "registration_flow_complete": {
        "category": "",
        "input": "Yes",
        "inserted_at": "2023-10-27T10: 36: 01.788664Z",
        "value": "Yes"
      }
}
@himeshr himeshr added the LAHI label Oct 27, 2023
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Oct 27, 2023
@himeshr himeshr moved this from New Issues to Ready in Avni Product Oct 27, 2023
@vinayvenu vinayvenu moved this from Ready to In Progress in Avni Product Nov 2, 2023
@vinayvenu vinayvenu self-assigned this Nov 2, 2023
vinayvenu added a commit that referenced this issue Nov 3, 2023
… FlowResult. Ability to use default BigQuery iterator.
vinayvenu added a commit that referenced this issue Nov 6, 2023
@vinayvenu vinayvenu moved this from In Progress to Code Review Ready in Avni Product Nov 8, 2023
@himeshr himeshr moved this from Code Review Ready to In Code Review in Avni Product Nov 8, 2023
@himeshr
Copy link
Author

himeshr commented Nov 8, 2023

Code Review comments:

*)
Set to simpledate using DateTimeUtil.registrationDate()
in

Date registrationDate = DateTimeUtil.toDate(lahiStudent.getDateOfRegistration(), DateTimeUtil.DATE_TIME);

*) Look into this test
"NoSuchElementExceptionWhenIteratingThroughAFullClass"

@himeshr himeshr moved this from In Code Review to Code Review with Comments in Avni Product Nov 8, 2023
@vinayvenu
Copy link
Member

Item 1 fixed
Item 2 should not be a problem. The method has been replaced

@vinayvenu vinayvenu moved this from Code Review with Comments to QA Ready in Avni Product Nov 8, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to Ready in Avni Product Nov 23, 2023
@AchalaBelokar AchalaBelokar moved this from Ready to QA Failed in Avni Product Nov 23, 2023
@himeshr himeshr moved this from QA Failed to In Progress in Avni Product Nov 27, 2023
@himeshr himeshr moved this from In Progress to Hold in Avni Product Nov 27, 2023
@himeshr
Copy link
Author

himeshr commented Nov 27, 2023

Need more info on the following issue reported:
When we are clicking on subject type it is showing opps there was a problem when loading this page.

@himeshr himeshr moved this from Hold to QA Ready in Avni Product Nov 27, 2023
@himeshr
Copy link
Author

himeshr commented Nov 27, 2023

https://docs.google.com/spreadsheets/d/191uuBE2R9Q8U0WKfBDsfECX0OiI0zXHpjkBxiZPeK58/edit#gid=346525539

Fixed the reproducible issues reported in the Error sheet.

@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 27, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 27, 2023
@mahalakshme mahalakshme removed the LAHI label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants