Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix. OpenMRSLoginAuthenticator to read JESESSIONID from cookie #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohan-13
Copy link

@mohan-13 mohan-13 commented Jun 2, 2023

Context:
With latest OpenMRS upgrade and upgrade of webservices rest module, the /ws/rest/v1/session endpoint does not return sessionId in the body. Instead it should be read from the cookie. This fixes it by reading and extracting it from the cookie.

This may not be an immediate merge for product, unless you move to latest versions of Bahmni

Copy link

@petmongrels petmongrels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this can be implemented by making a check on whether the session id is present in the response and if not then extract it from the cookie?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants