avocado.utils.kernel: fix kernel version parsing #6069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two problems with the current version parse mechanism:
1. Recent setuptools' version parse function, which has dropped
"LegacyVersion" support, raises an InvalidVersion exception
for common kernel version info as presented by the system and
returned by os.uname()
2. The import of the packaging module is broken on systems with no
setuptools and only the "packaging" module.
This introduces a simple but custom version parse that solves both and
simplifies dependencies.
Fixes: avocado-framework#6058
Signed-off-by: Cleber Rosa <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6069 +/- ##
==========================================
+ Coverage 54.44% 54.47% +0.02%
==========================================
Files 202 202
Lines 21890 21892 +2
==========================================
+ Hits 11918 11925 +7
+ Misses 9972 9967 -5 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two problems with the current version parse mechanism:
Recent setuptools' version parse function, which has dropped "LegacyVersion" support, raises an InvalidVersion exception for common kernel version info as presented by the system and returned by os.uname()
The import of the packaging module is broken on systems with no setuptools and only the "packaging" module.
This introduces a simple but custom version parse that solves both and simplifies dependencies.
Fixes: #6058