Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SearchScreen Complete #7

Merged
merged 1 commit into from
Sep 8, 2024
Merged

SearchScreen Complete #7

merged 1 commit into from
Sep 8, 2024

Conversation

dungd200803btvn
Copy link

Related Tickets

WHAT

  • Search weather forecast based on location name

Evidence (Screenshot or Video)

image

Review Checklist

Category View Point Description Expected Reviewer Answer Self review Reviewer2 (name)
Conventions Does the code follow Sun* coding style and coding conventions? https://github.com/framgia/coding-standards/blob/master/eng/android/coding_convention_android_kotlin.md YES
  • yes
    		•
  • yes
    		•
    Redmine Does the ticket follow Sun* Redmine working process? https://github.com/framgia/Training-Guideline/blob/master/WorkingProcess/redmine/redmine.md YES
  • yes
    		•
  • yes
    		•
    Documentation Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’? YES
  • yes
    		•
  • yes
    		•

    Notes (Optional)

    (Impacted Areas in Application(List features, api, models or services that this PR will affect))

    (Other notes)

    @dungd200803btvn dungd200803btvn changed the base branch from master to develop September 6, 2024 11:13
    daolq-2712
    daolq-2712 reviewed Sep 8, 2024
    View reviewed changes
    app/src/main/java/com/sun/weather/utils/listener/OnFetchListener.kt Outdated

    import android.location.Location

    interface OnFetchListener {
    Copy link
    Contributor

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Suggested change
    interface OnFetchListener {
    interface OnLocationChangeListener {

    daolq-2712
    daolq-2712 requested changes Sep 8, 2024
    View reviewed changes
    Copy link
    Contributor

    @daolq-2712 daolq-2712 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Pls check my comment!

    daolq-2712
    daolq-2712 approved these changes Sep 8, 2024
    View reviewed changes
    Copy link
    Contributor

    @daolq-2712 daolq-2712 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    OK!

    @daolq-2712 daolq-2712 merged commit 423de25 into awesome-academy:develop Sep 8, 2024
    1 check passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @daolq-2712 daolq-2712 daolq-2712 approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    2 participants
    @dungd200803btvn @daolq-2712