[Task #6697] offline music #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready |
tienpx3010
reviewed
Mar 6, 2019
| } | ||
|
|
||
| private func setupViews() { | ||
| navigationItem.title = NavigationConstant.offlineMusicNavItemTitle | ||
| tableView.then { |
There was a problem hiding this comment.
Suggested change
| tableView.then { | |
| tableView.do { |
|
|
||
| private func getLocalMusic() { | ||
| let secondQuery = MPMediaQuery.songs() | ||
| guard let result = secondQuery.collections else { return } |
There was a problem hiding this comment.
Suggested change
| guard let result = secondQuery.collections else { return } | |
| guard let result = MPMediaQuery.songs().collections else { return } |
| musicPlayer.index = 0 | ||
| musicPlayer.stop() | ||
| let url = musicPlayer.prepare(index: 0) | ||
| musicPlayer.play(url: url) |
There was a problem hiding this comment.
chỉ gọi method play() còn các method khác để trước khi play thì bỏ vào method play() của MediaManager
| guard let result = secondQuery.collections else { return } | ||
| for item in result { | ||
| let track = Track() | ||
| guard let representativeItem = item.representativeItem else { return } |
| musicPlayer.index = indexPath.row - 1 | ||
| musicPlayer.stop() | ||
| let streamUrl = musicPlayer.prepare(index: musicPlayer.index) | ||
| musicPlayer.play(url: streamUrl) |
There was a problem hiding this comment.
chỉ gọi method play() còn các method khác để trước khi play thì bỏ vào method play() của MediaManager
| } | ||
|
|
||
| func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { | ||
| if indexPath.row > 0 { |
There was a problem hiding this comment.
Nếu click lại vào bài đang chạy thì nó hiển thị player lên thôi chứ không chạy lại bài hát
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Pull request title]
Offline Music
[Redmine link]
https://edu-redmine.framgia.vn/issues/6697
Screenshots (nếu có)