chore(auth): Refactor to eliminate circular dependencies #14173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Prior to [email protected], analyzing the Auth package for circular dependencies yields no issues:
With the introduction of [email protected], the same analysis shows circular dependencies were introduced:
This PR extracts functions from the monolithic
signInHelpers
to eliminate the circular dependencies$ git checkout chore/eliminate-circular-dependencies $ npx dpdm -T --no-tree --no-warning packages/auth/src/index.ts ✅ Congratulations, no circular dependency was found in your project.
Issue #, if available
#14150
Description of how you validated changes
dpdm
analyzer to ensure the Auth entry point no longer resulted in circular dependencies.yarn test
Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.