Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authenticator): add react native support for email mfa #6344

Open
wants to merge 24 commits into
base: james/feat-email-mfa/react-updates
Choose a base branch
from

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented Feb 11, 2025

Description of changes

The purpose of this pull request is to expand authenticator support for email mfa.

The react native authenticator now renders two new screens in response to the two new states added to the state machine in #6317. This update allows completion of email MFA based sign ins, email MFA setup, and the selection challenges that allow users to choose which MFA method to setup or sign in with.

selectMfaType -> SelectMfaType : CONTINUE_SIGN_IN_WITH_MFA_SETUP and CONTINUE_SIGN_IN_WITH_MFA_SELECTION
setupEmail -> SetupEmail : CONTINUE_SIGN_IN_WITH_EMAIL_SETUP

Issue #, if available

Description of how you validated changes

  • manual testing
  • e2e tests
    image

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Latest commit: b13c415

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jjarvisp jjarvisp marked this pull request as ready for review February 11, 2025 02:01
@jjarvisp jjarvisp requested a review from a team as a code owner February 11, 2025 02:01
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch from 33a2a10 to cda3633 Compare February 11, 2025 19:04
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-native-updates branch from 700f2c5 to 7b32513 Compare February 11, 2025 19:05
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-native-updates branch from 7b32513 to 42571c4 Compare February 11, 2025 23:35
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-native-updates branch from 42571c4 to b13c415 Compare February 17, 2025 19:19
@jjarvisp jjarvisp force-pushed the james/feat-email-mfa/react-updates branch 3 times, most recently from c46c2ec to f69c422 Compare February 22, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants