-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 - Update to switch to CloudFormation provider schemas #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kddejong
force-pushed
the
v1
branch
2 times, most recently
from
February 12, 2023 21:11
ad0475c
to
e0cd8f7
Compare
@PatMyron Big changes here Provider schema files on disk size. ➜ cfn-python-lint git:(v1) du -sh src/cfnlint/data/ProviderSchemas
12M src/cfnlint/data/ProviderSchemas
➜ cfn-python-lint git:(v1) du -sh src/cfnlint/data/ProviderSchemas/us-east-1
6.4M src/cfnlint/data/ProviderSchemas/us-east-1
➜ cfn-python-lint git:(v1) du -sh src/cfnlint/data/ProviderSchemas/us-west-2
68K src/cfnlint/data/ProviderSchemas/us-west-2 |
kddejong
force-pushed
the
v1
branch
14 times, most recently
from
February 16, 2023 22:07
feea0d8
to
efd7e7e
Compare
37 tasks
kddejong
force-pushed
the
v1
branch
7 times, most recently
from
March 9, 2023 18:25
b15b602
to
02a545c
Compare
* Patch dynamodb tables to check schemas * Switch to keywords and add prefixItems * Remove requiredOr for anyOf
* More cleanup to change APIs * Update specs from 2024/04/15
* Check for unsupported element combination * Updating tests for principal
* Update how we set regions in Template class * Add il-central-1 region schemas
Co-authored-by: kddejong <[email protected]>
* Fix resource type error message syntax * Update tests for alphabetic ordering
* Update CloudFormation schemas to 2024-05-01 --------- Co-authored-by: kddejong <[email protected]> Co-authored-by: Kevin DeJong <[email protected]>
* Add more testing to increase coverage * Create fixes and more tests
michael-k
reviewed
Jun 28, 2024
Comment on lines
+19
to
+20
resourcespecs = {} | ||
resourcetypes = resourcespecs["ResourceTypes"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Breaking Changes
match_resource_sub_properties
. This function is dependent on the old resource specsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.