Skip to content

Revert "Log response payload for better troubleshooting (#320)" #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

wbingli
Copy link

@wbingli wbingli commented Dec 5, 2020

This reverts commit 4bdae6e.

Issue #, if available:

Description of changes: Revert the response payload logs.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wbingli
Copy link
Author

wbingli commented Dec 5, 2020

The integration test is broken so far due to cfn command support module now.

Looking to fix it.

@johnttompkins
Copy link
Contributor

@wbingli
Copy link
Author

wbingli commented Dec 5, 2020

https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/pull/326/files to fix the integ

That fix doesn't work.

$ cfn init -vv -t AWS::Foo::Bar -a RESOURCE
Logging set up successfully
Running None: Namespace(artifact_type='RESOURCE', command=<function init at 0x7fc88596d378>, force=False, subparser_name=None, type_name='AWS::Foo::Bar', verbose=2, version=False)
Root directory: /tmp/tmp.5Ivhk6tjWz
Initializing new project
Loading project file '/tmp/tmp.5Ivhk6tjWz/.rpdk-config'
One language plugin found, defaulting to java
Language plugin: java
Init started
Enter a package name (empty for default 'software.amazon.foo.bar'): 
>> 

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#build-times-out-because-no-output-was-received
The build has been terminated

@wbingli
Copy link
Author

wbingli commented Dec 5, 2020

A PR to fix the build: #337

@wbingli wbingli merged commit 3abe4bf into aws-cloudformation:master Dec 5, 2020
@wbingli wbingli deleted the remove-logs branch December 5, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants