Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tutorial for AWS Private CA ACK Controller #2366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anbaig
Copy link

@anbaig anbaig commented Feb 28, 2025

Issue #, if available: N/A

Description of changes: Adding a tutorial for using AWS Private CA with ACK

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested a review from a-hilaly February 28, 2025 19:27
Copy link

ack-prow bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anbaig
Once this PR has been reviewed and has the lgtm label, please assign jlbutler for approval by writing /assign @jlbutler in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from jlbutler February 28, 2025 19:27
Copy link
Member

@michaelhtm michaelhtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @anbaig thanks for the contribution!!
Left one inline comment

Comment on lines +316 to +331

```
apiVersion: services.k8s.aws/v1alpha1
kind: AdoptedResource
metadata:
name: adopted-ca
spec:
aws:
arn: arn:aws:acm-pca:us-east-1:111111111111:certificate-authority/9f0d73ed-be9c-49bb-a8bf-009bee09fdc8
kubernetes:
group: acmpca.services.k8s.aws
kind: CertificateAuthority
metadata:
name: adopted-ca
namespace: default
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recently introduced https://aws-controllers-k8s.github.io/community/docs/user-docs/features/#resourceadoption adoption by annotation feature. We do plan on deprecating the AdoptedResource CRD in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants