-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added launch template and launch templateversion as resource #146
base: main
Are you sure you want to change the base?
added launch template and launch templateversion as resource #146
Conversation
Hi @rkurduka. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rkurduka The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Any update or changes require on this , please let me know |
Please let me know if anything else is require here , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is nice!, thank you @rkurduka!
I have one global comment before dropping detailed ones. Ideally this PR need to be split into two PRs, each introducing one resource. This makes it easier to review and revert if needed in the future. Since this controller is GA we will need to add e2e tests for each of the resource, validating the happy path of each operation.
/ok-to-test
- LaunchTemplateVersion | ||
- LaunchTemplate | ||
#- LaunchTemplateVersion | ||
#- LaunchTemplate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split those changes into two PRs? one adding LunchTemplate
and one adding LunchTemplateVersion
? it easier to review, revert if ever needed.
raised separate PR - 151 for launch template only - will raise separate one for launch template version |
Issues go stale after 180d of inactivity. |
@rkurduka: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issue #, if available: #1841
Description of changes:
EC2 resource added - Launch template and LaunchTemplateversion
Functionalities:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.