Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added launch template and launch templateversion as resource #146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rkurduka
Copy link

Issue #, if available: #1841

Description of changes:

EC2 resource added - Launch template and LaunchTemplateversion

Functionalities:

  1. Create ec2 launch template
  2. set default version for launch template
  3. Create new versions of launch template ( separate resource launchtemplateversions)
  4. Delete launch template versions
  5. Delete launch template and its versions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
Copy link

ack-prow bot commented Aug 10, 2023

Hi @rkurduka. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 10, 2023
@ack-prow ack-prow bot requested a review from RedbackThomson August 10, 2023 08:37
@ack-prow
Copy link

ack-prow bot commented Aug 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rkurduka
Once this PR has been reviewed and has the lgtm label, please assign vijtrip2 for approval by writing /assign @vijtrip2 in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot requested a review from vijtrip2 August 10, 2023 08:37
@rkurduka
Copy link
Author

Any update or changes require on this , please let me know

@rkurduka
Copy link
Author

Please let me know if anything else is require here ,

Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice!, thank you @rkurduka!

I have one global comment before dropping detailed ones. Ideally this PR need to be split into two PRs, each introducing one resource. This makes it easier to review and revert if needed in the future. Since this controller is GA we will need to add e2e tests for each of the resource, validating the happy path of each operation.

/ok-to-test

- LaunchTemplateVersion
- LaunchTemplate
#- LaunchTemplateVersion
#- LaunchTemplate
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split those changes into two PRs? one adding LunchTemplate and one adding LunchTemplateVersion ? it easier to review, revert if ever needed.

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2023
@rkurduka
Copy link
Author

rkurduka commented Oct 4, 2023

raised separate PR - 151 for launch template only - will raise separate one for launch template version

@ack-bot
Copy link
Collaborator

ack-bot commented Apr 1, 2024

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 1, 2024
@a-hilaly a-hilaly removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 15, 2024
Copy link

ack-prow bot commented Aug 30, 2024

@rkurduka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ec2-release-test d112707 link true /test ec2-release-test
ec2-metadata-file-test d112707 link true /test ec2-metadata-file-test
ec2-unit-test d112707 link true /test ec2-unit-test
ec2-kind-e2e d112707 link true /test ec2-kind-e2e
ec2-recommended-policy-test d112707 link true /test ec2-recommended-policy-test
ec2-verify-attribution d112707 link true /test ec2-verify-attribution

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants