-
Notifications
You must be signed in to change notification settings - Fork 4
Align README.md content with other controllers. #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Based on intros in s3, iam, and rds controllers.
Hi @jjshanks. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@a-hilaly and @michaelhtm it's been 2 months since this was opened, just checking in on if you need anything else to proceed. |
Hi @jjshanks, thanks for the contribution! Will merge soon. Update: https://github.com/aws-controllers-k8s/ec2-controller/edit/main/README.md is written the same way as the REadME in this controller... there are some inconsistencies i noticed between the controllers, i'm not sure if we should go back and update all. |
@jjshanks: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
To me it looks like there is indeed a generation bug for recyclebin README. We definetely need to think about generating READMEs for all the controllers, and we can still merge this as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jjshanks !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, jjshanks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on intros in s3, iam, and rds controllers.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.