-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix - handled panic due to difference in InputdataConfig size #275
base: main
Are you sure you want to change the base?
Bugfix - handled panic due to difference in InputdataConfig size #275
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ankurjha7 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ankurjha7. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @aws-controllers-k8s/sagemaker-maintainer |
/assign @a-hilaly |
Issues go stale after 180d of inactivity. |
Description of changes:
The change handles panic due to runtime error : index out of range . The present code accesses b.ko.Spec.InputDataConfig[index] which can throw panic if size of b.ko.Spec.InputDataConfig is smaller than a.ko.Spec.InputDataConfig
The solution checks for this condition and sets the a.ko.Spec.InputDataConfig[index].RecordWrapperType to default type
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.