Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete mwaa resource lifecycle block with ignore changes #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arnoldasjan
Copy link

What does this PR do?

This PR deletes lifecycle block from MWAA resource in order to update MWAA whenever requirements or plugins objects version changes.

Motivation

Motivation is to avoid restarting MWAA manually after update in requirements.txt or plugins.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@arnoldasjan arnoldasjan requested review from vara-bonthu and a team as code owners January 4, 2024 14:19
@VolkerSchiewe
Copy link

Thanks for opening the PR! We ran into this issue while upgrading MWAA and trying to update the requirements.txt file accordingly.

@vara-bonthu is there anything blocking this change?

@vara-bonthu vara-bonthu requested review from vara-bonthu and removed request for a team April 19, 2024 19:07
@vara-bonthu
Copy link
Collaborator

Please resolve the conflicts so that we can merge the PR

@calebAtIspot
Copy link
Contributor

It would be nice to still have a option to ignore these values. In our workflow we upload files to S3 via CI/CD. We don't have it built yet but eventually we plan on automatically updating these values from our CI/CD pipeline.

@kingcrunch
Copy link

It would be nice to still have a option to ignore these values. In our workflow we upload files to S3 via CI/CD. We don't have it built yet but eventually we plan on automatically updating these values from our CI/CD pipeline.

Since this are variables I would expect this somehow outside of this module. Problem remains, that once it is in this module, it is enforced for everyone.

@kingcrunch
Copy link

@vara-bonthu superseded by #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants